Radicore Forum: Bug Reports » Insertorupdate and autoincrement

Home » RADICORE development » Bug Reports » Insertorupdate and autoincrement

Show: Today's Messages :: Polls :: Message Navigator
E-mail to friend

Insertorupdate and autoincrement [message #1792]

Thu, 06 November 2008 05:46

bonzo_bcn
Messages: 152
Registered: June 2008

Senior Member

I think there is a bug in the insertOrUpdate function.
I have a field in the table where I'm inserting te record that is autoincrement and pk.
With this code:

Code: [Select all] [Show/ hide]

if ($existing_participante_id > 0){

  $insert_array['participante_id'] = $existing_participante_id;

}
$insert_array['tippart'] = 'E';
$insert_array['catsalut'] = $data['catsalut'];
$insert_array['nompart'] = $data['nompart'];
$insert_array['apellido1'] = $data['apellido1'];
$insert_array['apellido2'] = $data['apellido2'];

$insert_array = $participante->insertOrUpdate($insert_array);

I don't get returned the generated autoincrement in $insertarray

on the other hand, if I do it like this:

Code: [Select all] [Show/ hide]

if ($existing_participante_id > 0){

				
	$insert_array = $participante->updateRecord($insert_array);

}else{
				
				
	$insert_array = $participante->insertRecord($insert_array);
			}

the autoincrement is returned in $insert_array

Report message to a moderator

Re: Insertorupdate and autoincrement [message #1793 is a reply to message #1792]

Thu, 06 November 2008 09:09

AJM
Messages: 2382
Registered: April 2006
Location: Surrey, UK

Senior Member

The behaviour you describe is as expected. Columns with the auto_increment attribute act as follows:

(a) During an INSERT if an auto_increment column has a value which is greater than zero then that value will be used, and a new one will not be generated. It is normal practice not to supply any value, not even zero, for an auto_increment column.

(b) The insertOrUpdate() function will construct a WHERE string using the current primary key and perform a lookup to find out if the record exists or not. If the primary key is auto_increment then for an INSERT there is no value, so the result of the lookup is unpredictable.

In short, do not use the insertOrUpdate() function to insert records which rely on auto_increment to supply their values. In this case you should examine the value yourself and call either insertRecord() or updateRecord() manually.

Tony Marston
http://www.tonymarston.net
http://www.radicore.org

Report message to a moderator

Re: Insertorupdate and autoincrement [message #1803 is a reply to message #1793]

Sat, 08 November 2008 11:11

AJM
Messages: 2382
Registered: April 2006
Location: Surrey, UK

Senior Member

I have modified the insertOrUpdate() method so that it calls isPkeyComplete() before performing the database lookup. If the primary key is not complete, such as when an auto_increment column has not been specified, then it will skip the lookup and force an INSERT.

It is therefore imperative that when wanting to perform an INSERT on a table which contains an auto_increment key that the column does not appear in the field array. If it appears with any value, even NULL or ZERO, then isPkeyComplete() will return TRUE and a lookup will be performed.

Please see the attached file for the patched code.

Attachment: radicore-2008-11-08-update2.zip
(Size: 133.90KB, Downloaded 1330 times)

Tony Marston
http://www.tonymarston.net
http://www.radicore.org

Report message to a moderator

Previous Topic:	Multi2 -> popup2 not calling _cm_pre_updateRecord?
Next Topic:	Problem with accentuated char and Uppercase

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sat Jul 05 22:40:59 EDT 2025

Total time taken to generate the page: 0.10380 seconds