Radicore Forum: Bug Reports » Tabs in php files

Home » RADICORE development » Bug Reports » Tabs in php files (RADICORE programming guidelines)

Show: Today's Messages :: Polls :: Message Navigator
E-mail to friend

Tabs in php files [message #3354]

Mon, 21 January 2013 23:32

jjtoranzo2004
Messages: 261
Registered: September 2012

Senior Member

Tony,

First of all this is not a bug report, it a coding convention report. I didn't find a better place to put it.

Contrary to what I expected after reading "PHP programming tips" section, tip number 12
http://www.radicore.org/viewarticle.php?article_id=64

I found tabs in some Radicore files present in the \radicore\includes directory.

nusoap.php
include.library.inc
browser_detection.inc
std.pdf.class.inc
std.table.class.inc
include.session.inc
dml.oracle.php5.class.inc
dml.oracle.php4.class.inc
dml.pgsql.class.inc
dml.sqlsrv.class.inc
include.xml.php4.inc
include.xml.php5.inc
des.php
dml.mysqli.class.inc
dml.mysql.class.inc
std.xmlrpc.inc
std.batch.inc
std.soap.php4.inc
std.search1.inc
std.soap.inc
language_detection.inc
std.validation.class.inc
std.fileupload1.inc
std.datevalidation.class.inc
std.filepicker1.inc
std.filepicker2.inc
std.soap.php5.inc
flubit_defines.inc
std.encryption.class.inc
std.multi1.inc
std.singleton.php5.inc
std.add5.inc
std.imap.class.inc
std.multi2.inc
error.inc
std.singleton.php4.inc
std.add2.inc
std.update1.inc
std.add1.inc
std.multi4.inc
std.output3.inc
std.list2.inc
std.link1.inc
std.output1.inc
std.pdf_list.class.inc
std.list1.inc
std.update3.inc
std.list3.inc
std.delete1.inc
std.multi3.inc
std.output2.inc
std.output5.inc
include.general.inc
std.enquire1.inc
std.output4.inc
std.update4.inc
std.tree_view1.inc
std.add3.inc
std.tree_view2.inc
std.add4.inc
std.update2.inc
std.delete4.inc
std.update5.inc
std.help.inc
std.filedownload2.inc
std.filedownload1.inc
std.delete2.inc

I know that some of them perhaps were written by other authors.

\radicore\css
Tabs in css files are not mentioned in the guidelines, but ...
Tabs came to my attention when I was looking at one css file in my text editor and I noticed that a line had more indentation than the others.
The cause, a tab. Most lines were indented with two spaces but my text editor displays a tab as four spaces.

I also found tabs in these files in \radicore\css

blackwoods-narrow.css
blackwoods-wide.css
blue.css
blue-narrow.css
blue-wide.css
default.css
default-narrow.css
default-wide.css
emerald.css
emerald-narrow.css
emerald-wide.css
plum.css
plum-narrow.css
plum-wide.css
wrd.css
wrd-narrow.css
wrd-wide.css

Perhaps you would like to make a global search and replace and adjust your IDE settings.

Thanks for everything.

Report message to a moderator